[webkit-reviews] review requested: [Bug 29103] typeAheadFind in select element is case-sensitive for Cyrillic and Greek : [Attachment 39415] a quick fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 11 01:26:27 PDT 2009


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 29103: typeAheadFind in select element is case-sensitive for Cyrillic and
Greek
https://bugs.webkit.org/show_bug.cgi?id=29103

Attachment 39415: a quick fix
https://bugs.webkit.org/attachment.cgi?id=39415&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
This change just replaces WTF::toASCIILower() calls in
StringImpl::reverseFind() with WTF::Unicode::toLower() for non-ASCII
characters.
I'm not sure why StringImpl::reverseFind() uses WTF::toASCIILower(), though.
(Performance issue?)


More information about the webkit-reviews mailing list