[webkit-reviews] review denied: [Bug 29077] [v8] Share persistent context handles between events : [Attachment 39413] tweaks

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Christian Plesner Hansen
<christian.plesner.hansen at gmail.com>'s request for review:
Bug 29077: [v8] Share persistent context handles between events
https://bugs.webkit.org/show_bug.cgi?id=29077

Attachment 39413: tweaks
https://bugs.webkit.org/attachment.cgi?id=39413&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm worried about how this interacts with weak handles.  For example, we lose

- m_context.makeWeak();

in V8AbstractEventListener.cpp.  That seems like it might cause problems...

Also,

-    m_context.MakeWeak(this, &contextWeakReferenceCallback);
+    m_context->get().MakeWeak(this, &contextWeakReferenceCallback);

in V8IsolatedWorld.cpp.  Won't that make the shared handle weak?  Doesn't
V8Proxy need to hold a strong reference to the context?