[webkit-reviews] review granted: [Bug 29136] [Qt] emit microFocusChanged() signal when no QWidget-based view is present. : [Attachment 39363] emit microFocusChanged() regardless of view.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 29136: [Qt] emit microFocusChanged() signal when no QWidget-based view is
present.
https://bugs.webkit.org/show_bug.cgi?id=29136

Attachment 39363: emit microFocusChanged() regardless of view.
https://bugs.webkit.org/attachment.cgi?id=39363&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me, thanks

This is a correct change, but I think it will need more work to fully function.
This ties into the discussion about
making QWebPage work better in environments without a view but a graphics item
instead. Just emitting the signal
helps, but it's not sufficient to determine then if the input method should be
enabled or not.

Please see also the discussion in #28862 and the follow-up in #29085. We could
benefit from your experience in using it without a view :)