[webkit-reviews] review granted: [Bug 28327] Media layout tests should have a way to provide test files in different formats : [Attachment 39405] Second round of changes - 20 tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 10 23:38:29 PDT 2009
Eric Carlson <eric.carlson at apple.com> has granted Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 28327: Media layout tests should have a way to provide test files in
different formats
https://bugs.webkit.org/show_bug.cgi?id=28327
Attachment 39405: Second round of changes - 20 tests
https://bugs.webkit.org/attachment.cgi?id=39405&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> - // controller should still be visible after a second
> - setTimeout(function() { layoutTestController.notifyDone(); }
, 1000);
> - }
> + setTimeout(function() {
> + if (window.layoutTestController)
> + layoutTestController.notifyDone();
> + } , 1000);
Is there any reason to remove the comment about what the 1 second timeout is
for?
r=me
More information about the webkit-reviews
mailing list