[webkit-reviews] review denied: [Bug 29143] Added MathML toggle to build script : [Attachment 39371] Updated patch with tab removed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 22:18:39 PDT 2009


Mark Rowe (bdash) <mrowe at apple.com> has denied Alex Milowski
<alex at milowski.com>'s request for review:
Bug 29143: Added MathML toggle to build script
https://bugs.webkit.org/show_bug.cgi?id=29143

Attachment 39371: Updated patch with tab removed
https://bugs.webkit.org/attachment.cgi?id=39371&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The variable and option declarations are in alphabetical order.  The new
variable and option should maintain that.  I think it would be best for MathML
to be disabled by default until the implementation is more complete and tested.
 Other than those minor issues, this change is fine.


Marking as r- as a revised patch will need to be posted before we can commit
it.


More information about the webkit-reviews mailing list