[webkit-reviews] review requested: [Bug 29165] Remove duplicated WK_{u, l}cfirst subs from CodeGeneratorV8.pm : [Attachment 39399] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 17:31:15 PDT 2009


Cameron McCormack <cam at mcc.id.au> has asked  for review:
Bug 29165: Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=29165

Attachment 39399: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39399&action=review

------- Additional Comments from Cameron McCormack <cam at mcc.id.au>
I note that the WK_lcfirst in CodeGenerator.pm is different from the one in
CodeGeneratorV8.pm.  The only case that CodeGeneratorV8 calls WK_lcfirst for is
the "URL" attribute on Document (and a couple of other interfaces), so there
should be no change in output.	I inspected the output of running
generate-bindings.pl on Document visually, but didn't build anything to test (I
guess I'd need to check out Chromium to do that).


More information about the webkit-reviews mailing list