[webkit-reviews] review requested: [Bug 29134] [GTK] Add API to access sub resources : [Attachment 39366] proposed API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 12:10:48 PDT 2009


Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 29134: [GTK] Add API to access sub resources
https://bugs.webkit.org/show_bug.cgi?id=29134

Attachment 39366: proposed API
https://bugs.webkit.org/attachment.cgi?id=39366&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Points worth noting:

WebView is used to store the hash table because the DataSource object is only
created after the first resource was already created; I would appreciate
suggestions on where to place the hash table in a way that we don't need to get
to the WebView from the DataSource, since I believe the API should be in the
DataSource.

Some things are done in a way that seems a bit convoluted (the main resource
handling, for instance), but that is because I really want the resource objects
to be exactly the same through their lifetime, so that you can keep objects you
get in resource-request-starting, and even compare them with other references
to know if they are the same.


More information about the webkit-reviews mailing list