[webkit-reviews] review denied: [Bug 28921] Tablet Input Panel Icon does not show up by text fields : [Attachment 39095] Updated Fix

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 28921: Tablet Input Panel Icon does not show up by text fields
https://bugs.webkit.org/show_bug.cgi?id=28921

Attachment 39095: Updated Fix
https://bugs.webkit.org/attachment.cgi?id=39095&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +    Node* focusedNode = document()->focusedNode();
> +    if (!focusedNode || !focusedNode->renderer() 
> +	   || !(focusedNode->renderer()->isTextField() ||
focusedNode->renderer()->isTextArea()))
> +	   return;

What about something like <div contenteditable>?

> +    HBITMAP caretBitmap = ::CreateBitmap(0, 0, 1, 1, NULL);
> +    ::CreateCaret(widget, caretBitmap, 0, 0);
> +    ::ShowCaret(widget);
> +
> +    IntPoint contentPoint = selection()->absoluteCaretBounds().topLeft();
> +    
> +    IntPoint windowPoint = view()->contentsToWindow(contentPoint);
> +    ::SetCaretPos(windowPoint.x(), windowPoint.y());
> +
> +    ::DeleteObject(caretBitmap);

Should we just cache the empty bitmap? It seems kind of silly to create/destroy
it every time the caret moves.

Does updateWindowsSystemCaret get called in response to
WM_SETFOCUS/WM_KILLFOCUS? I'm still worried we aren't calling it at the right
times.