[webkit-reviews] review denied: [Bug 25930] Mismatched free : [Attachment 39352] updated proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 09:33:32 PDT 2009


Darin Adler <darin at apple.com> has denied  review:
Bug 25930: Mismatched free
https://bugs.webkit.org/show_bug.cgi?id=25930

Attachment 39352: updated proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=39352&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	   delete reinterpret_cast<char*>(selectorVector[i]);
> +	  
fastDeleteSkippingDestructor(reinterpret_cast<char*>(selectorVector[i]));

This is wrong. There is no need for the reinterpret_cast any more. Also the
comment needs to be updated.


More information about the webkit-reviews mailing list