[webkit-reviews] review granted: [Bug 29077] [v8] Share persistent context handles between events : [Attachment 39340] updated

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Christian Plesner Hansen
<christian.plesner.hansen at gmail.com>'s request for review:
Bug 29077: [v8] Share persistent context handles between events
https://bugs.webkit.org/show_bug.cgi?id=29077

Attachment 39340: updated
https://bugs.webkit.org/attachment.cgi?id=39340&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ PassRefPtr<SharedPersistent<v8::Context> > context = proxy->shared_context();


We don't usually hold PassRefPtrs as local variables.  They're a bit tricky to
use like this b/c they like to null themselves out.  In this case, we're fine,
but I wanted to make sure you're realized what you were doing was somewhat
subtle.

+	 No new tests. (OOPS!)

This line will be rejected by the pre-submit checks.  We can either land this
manually, or we can land it automatically if you upload a new patch without
this line.