[webkit-reviews] review requested: [Bug 28806] [Qt] Make the WebInspector available as a widget class. : [Attachment 39347] Changes v0.5

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 28806: [Qt] Make the WebInspector available as a widget class.
https://bugs.webkit.org/show_bug.cgi?id=28806

Attachment 39347: Changes v0.5
https://bugs.webkit.org/attachment.cgi?id=39347&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Stuff that may be worth noting about this patch relatively to v0.4:

The inspectedElement argument to the webInspectorTriggered signal is currently,
as I saw, always the same as the focused element in the inspector.
However this is mostly luck since we can't create QWebElements out of non-html
nodes and the inspector also seems to focus on the enclosing Html element.

For example if we right click on a text node in the page, the hittestresult
will contain a WebCore::Text node.
- This patch will walk the parents until a QWebElement can be created from the
hittestresult's parents before giving it to the signal.
- The web inspector will select the surrounding <font> element, however I would
not expect this behavior since the text node is available for selection and it
may change in the future.

I documented in the signal that the inspectedElement argument is not garanteed
to be the same.
There is also the possibility of not giving this argument in the signal, since
the user may expect the same value and it may feel unreliable.

Please tell me what you think.