[webkit-reviews] review denied: [Bug 25930] Mismatched free : [Attachment 39346] updated proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied  review:
Bug 25930: Mismatched free
https://bugs.webkit.org/show_bug.cgi?id=25930

Attachment 39346: updated proposed patch
https://bugs.webkit.org/attachment.cgi?id=39346&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: JavaScriptCore/wtf/HashSet.h
> ===================================================================
> --- JavaScriptCore/wtf/HashSet.h	(revision 47860)
> +++ JavaScriptCore/wtf/HashSet.h	(working copy)
> @@ -91,7 +91,7 @@ namespace WTF {
>  
>      private:
>	   friend void deleteAllValues<>(const HashSet&);
> -
> +    public:
>	   HashTableType m_impl;
>      };

Wait, this isn't right!? m_impl should not be public! The fastDeleteAllValues
function needs to be a friend just as deleteAllValues is.