[webkit-reviews] review denied: [Bug 29099] Geolocation does not correctly handle Infinity for PositionOptions properties. : [Attachment 39315] Patch 2 for bug 29099

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Steve Block <steveblock at google.com>'s
request for review:
Bug 29099: Geolocation does not correctly handle Infinity for PositionOptions
properties.
https://bugs.webkit.org/show_bug.cgi?id=29099

Attachment 39315: Patch 2 for bug 29099
https://bugs.webkit.org/attachment.cgi?id=39315&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
So would:
 109	     if (!(isinf(timeoutNumber) && (timeoutNumber > 0))) {
if (isfinite(timeoutNumber))

get you the same effect?  negativeInfinity will be ignored, which is maybe the
wrong behavior?

Also, shouldn't we be testing negative infinity in the test cases?  Do the
tests test any negative numbers?