[webkit-reviews] review denied: [Bug 29041] HTMLMediaElement buffered attribute should report a list of time range : [Attachment 39310] patch to be submitted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 16:49:21 PDT 2009


Eric Carlson <eric.carlson at apple.com> has denied Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 29041: HTMLMediaElement buffered attribute should report a list of time
range
https://bugs.webkit.org/show_bug.cgi?id=29041

Attachment 39310: patch to be submitted
https://bugs.webkit.org/attachment.cgi?id=39310&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> +
> +    if (duration == 0 || isinf(duration))
> +	   return 0;

"duration == 0" is a style violation, tests for zero/non-zero should be not be
done with an equality comparison.

check-webkit-style would have flagged this error.


More information about the webkit-reviews mailing list