[webkit-reviews] review requested: [Bug 29065] svn-unapply doesn't revert directories correctly : [Attachment 39309] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 9 16:34:30 PDT 2009
Cameron McCormack <cam at mcc.id.au> has asked for review:
Bug 29065: svn-unapply doesn't revert directories correctly
https://bugs.webkit.org/show_bug.cgi?id=29065
Attachment 39309: Patch v2
https://bugs.webkit.org/attachment.cgi?id=39309&action=review
------- Additional Comments from Cameron McCormack <cam at mcc.id.au>
(In reply to comment #2)
> it seems this repeated regexp really should be in a function, or at least as
a
> constant.
Done. Note also I fixed a small bug -- the second s/// I added was being
applied to $_ when it should have been applied to $svnStatus.
> Also, I think perl is slightly more readable when you make use of $_
explicit,
> so I prefer the old code.
I'd argue that leaving off the "$_ =~" is more idiomatic Perl, but OK, done.
Perhaps if I'd included it I would've picked up the above bug first time
around. :-)
More information about the webkit-reviews
mailing list