[webkit-reviews] review denied: [Bug 29099] Geolocation does not correctly handle Infinity for PositionOptions properties. : [Attachment 39283] Patch 1 for bug 29099

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 15:03:05 PDT 2009


Eric Seidel <eric at webkit.org> has denied Steve Block <steveblock at google.com>'s
request for review:
Bug 29099: Geolocation does not correctly handle Infinity for PositionOptions
properties.
https://bugs.webkit.org/show_bug.cgi?id=29099

Attachment 39283: Patch 1 for bug 29099
https://bugs.webkit.org/attachment.cgi?id=39283&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It's a little strange that this is the first use of Inf.  Makes me wonder if it
should be exported.  Obviously it must already be in a header somewhere.

In general this change looks fine.  I just find the Inf thing a bit strange. 
Isn't there a posix function for detecting infitiy in a double?  Only positive
infinity?  What about isinfinite(foo) instead?

I think r- for the strange Inf export and no discussion of handling negative
infinity or not.

We should probably say "positive infinity" instead of "infinity" in the
comments.


More information about the webkit-reviews mailing list