[webkit-reviews] review granted: [Bug 28862] [Qt][API] Add a new QGraphicsWidget based version of the "QWebView" : [Attachment 39299] Followup: Implement some virtual event methods so that we can fix event-related bugs in Qt patch releases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 14:09:36 PDT 2009


Tor Arne Vestbø <vestbo at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 28862: [Qt][API] Add a new QGraphicsWidget based version of the "QWebView"
https://bugs.webkit.org/show_bug.cgi?id=28862

Attachment 39299: Followup: Implement some virtual event methods so that we can
fix event-related bugs in Qt patch releases
https://bugs.webkit.org/attachment.cgi?id=39299&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Cool stuff, minor nitpick:

> +    // Swallow reimplementation in order to allows fixing event-related bugs
in patch releases

"Swallow"?

I think you can drop the comment, or at least fix the "allows" spelling and say
something like "Re-implemented in order ..."


More information about the webkit-reviews mailing list