[webkit-reviews] review requested: [Bug 29080] Geolocation Coordinates::toString() prints bogus values for unspecified properties. : [Attachment 39292] Patch 3 for bug 29080

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has asked  for review:
Bug 29080: Geolocation Coordinates::toString() prints bogus values for
unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080

Attachment 39292: Patch 3 for bug 29080
https://bugs.webkit.org/attachment.cgi?id=39292&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
> Nit 4space indent:
Fixed

>Probably needs a comment:
> +    position = p;  // shouldBe can't use local variables yet.
Fixed

> Oh, I see.  You modified the template to not include js-post.  In that case,
> you really should add this script to the exclusion list for
> make-script-test-wrappers.
Fixed, and also for asynchronous other Geolocation tests.

>  And possibly ignore my comments above about this being sync.
Yes, it's asynchronous.