[webkit-reviews] review granted: [Bug 29091] commit-queue hangs if a builder has never built : [Attachment 39276] Patch v1

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 29091: commit-queue hangs if a builder has never built
https://bugs.webkit.org/show_bug.cgi?id=29091

Attachment 39276: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39276&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r=me if there is a good answer to my question below.

> diff --git a/WebKitTools/Scripts/modules/buildbot.py
b/WebKitTools/Scripts/modules/buildbot.py
> +	   if not status_link:
> +	       # We failed to find a link in the first cell, just give up.
> +	       # This can happen if a builder is just-added, the first cell
will just be "no build"
> +	       return builder

Are other parts of the code robust to 'built_revision', 'is_green', 'build_url'
not being in builder?

> diff --git a/WebKitTools/Scripts/modules/buildbot_unittest.py
b/WebKitTools/Scripts/modules/buildbot_unittest.py
> +	 <td align="center" class="Activity building">building<br />< 1
min</td>

&lt; 1 min ?