[webkit-reviews] review denied: [Bug 28914] Add a test for iframe shims and windowed plugin : [Attachment 39004] Updated patch with style fixes

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Victor Wang
<victorw at chromium.org>'s request for review:
Bug 28914: Add a test for iframe shims and windowed plugin
https://bugs.webkit.org/show_bug.cgi?id=28914

Attachment 39004: Updated patch with style fixes
https://bugs.webkit.org/attachment.cgi?id=39004&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Almost there!

> +		   if (!tags.pluginNorelative) {
> +		       parentdiv.style.position = 'relative';
> +		   }

No braces around one-liners.

> +
> +		   if (pluginDivZ) {
> +		       parentdiv.style.zIndex = pluginDivZ;
> +		   }

Ditto.

> +		   root.appendChild(parentdiv);
> +	       } else {
> +		   if (!tags.pluginNorelative) {
> +		       pd.style.position = 'relative';

Ditto.


> +	       if (overlayDivZIframe) {
> +		   id.style.zIndex = overlayDivZIframe;

Ditto.


> +	       if (overlayDivZOverlay) {
> +	       od.style.zIndex = overlayDivZOverlay;
> +	       }

No braces + indent.

> +		   if (overlayDivZOverlay) {
> +		       parentdiv.style.zIndex = overlayDivZOverlay;
> +		   }

No braces.

> +	   for (k in expectedClicks) {
> +	       if (expectedClicks[k] && !clicks[k]) {
> +		   waitingForMoreClicks = true;
> +	    } else if (!expectedClicks[k] && clicks[k]) {

Indent issue here. Should be one more to indent w/if?