[webkit-reviews] review requested: [Bug 29080] Geolocation Coordinates::toString() prints bogus values for unspecified properties. : [Attachment 39271] Patch 2 for bug 29080

[bugzilla-daemon at webkit.org]

steveblock at google.com has asked  for review:
Bug 29080: Geolocation Coordinates::toString() prints bogus values for
unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080

Attachment 39271: Patch 2 for bug 29080
https://bugs.webkit.org/attachment.cgi?id=39271&action=review

------- Additional Comments from steveblock at google.com
> Coordinates::toString now does String appending, which requires new memory
> allocation for every single operation and is hence quite inefficient.
Fixed

> Does this textual version of the object match anyone else's Geolocation
> implementation?
Neither Gears nor Firefox provide custom toString() methods for their JS
position or coordinates objects.

> Is the behavior specified anywhere?
No, the spec does not mention this.