[webkit-reviews] review granted: [Bug 28963] AX notifications should be an ENUM type instead of strings : [Attachment 39245] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 28963: AX notifications should be an ENUM type instead of strings
https://bugs.webkit.org/show_bug.cgi?id=28963

Attachment 39245: patch
https://bugs.webkit.org/attachment.cgi?id=39245&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   // Notifications. Use strings provided for consistency.

What does "Use strings provided for consistency" mean? Who should use strings,
for what?

> +	   enum AXNotification {
> +	       AXCheckedStateChanged = 1,

Why the = 1 here? I recommend leaving that out unless you have some need for a
zero value.

r=me