[webkit-reviews] review granted: [Bug 29080] Geolocation Coordinates::toString() prints bogus values for unspecified properties. : [Attachment 39264] Patch 1 for bug 29080

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 07:33:39 PDT 2009


Darin Adler <darin at apple.com> has granted steveblock at google.com's request for
review:
Bug 29080: Geolocation Coordinates::toString() prints bogus values for
unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080

Attachment 39264: Patch 1 for bug 29080
https://bugs.webkit.org/attachment.cgi?id=39264&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Coordinates::toString now does String appending, which requires new memory
allocation for every single operation and is hence quite inefficient. It's a
better idiom to use StringBuilder or Vector<UChar>. Same comment about the
existing code in Geoposition::toString.

Does this textual version of the object match anyone else's Geolocation
implementation? Is the behavior specified anywhere?


More information about the webkit-reviews mailing list