[webkit-reviews] review requested: [Bug 28964] [Chromium] ChromiumDataObject should have getter/setter interface : [Attachment 39267] patch: add getter/setter accessor methods

[bugzilla-daemon at webkit.org]

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 28964: [Chromium] ChromiumDataObject should have getter/setter interface
https://bugs.webkit.org/show_bug.cgi?id=28964

Attachment 39267: patch: add getter/setter accessor methods
https://bugs.webkit.org/attachment.cgi?id=39267&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>

Removed 'inline' from methods.

> I take it that the "chromium code" in question lives outside of the WebKit
> tree?  So that we have to do this in two-stages like this?

Yes, the code in question is (Chromium) webkit\api\src\WebDragData.cpp .

The main reason for the change is that I want to implement
get/setData("text/uri-list") in Chromium.
(see https://bugs.webkit.org/show_bug.cgi?id=28293)
However, according to the HTML5 spec, "text/uri-list" and "URL" are not
independent.
So having WebDragData accessing a single 'url' member directly is inconvenient.


The getter/setter methods for the other members is just "collateral damage" ;)
(but it also allows cleaning up the naming).