[webkit-reviews] review granted: [Bug 28327] Media layout tests should have a way to provide test files in different formats : [Attachment 39249] 10 layout tests change

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 28327: Media layout tests should have a way to provide test files in
different formats
https://bugs.webkit.org/show_bug.cgi?id=28327

Attachment 39249: 10 layout tests change
https://bugs.webkit.org/attachment.cgi?id=39249&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>

> +function findMediaFile(type, name) {
> +function setSrcByTagName(tagName, src) {

  It would be clearer to use the same parameter names for the element type for
both functions, I think "tagName" is clearer than "type".
  

> +function setSrcById(id, src) {
> +    var elements = document.getElementById(id);
> +    if (elements)
> +	   id.src = src;

  getElementById can only return a single element, so "elements" doesn't need
to be plural.

r=me