[webkit-reviews] review requested: [Bug 29068] NPAPI Plugin NPP_AsFile not working on Qt Webkit : [Attachment 39247] Patch which solves the deletion of created temp file before passing to plugin in NPP_AsFile

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 23:09:41 PDT 2009


Rohini Ananth <rohini.ananth at nokia.com> has asked  for review:
Bug 29068: NPAPI Plugin NPP_AsFile not working on Qt Webkit
https://bugs.webkit.org/show_bug.cgi?id=29068

Attachment 39247: Patch which solves the deletion of created temp file before
passing to plugin in NPP_AsFile 
https://bugs.webkit.org/attachment.cgi?id=39247&action=review

------- Additional Comments from Rohini Ananth <rohini.ananth at nokia.com>
In the patch, in openTemporaryFile() method implemented for platform Qt in
FileSystemQt.cpp, the autoremove property has been set to false.Hence
closeFileHandle() just closes and does not delete the file before passing it to
plugin. As last step of PluginStream::destroystream, anyways the deletion of
this temp file has been taken care.


More information about the webkit-reviews mailing list