[webkit-reviews] review requested: [Bug 29065] svn-unapply doesn't revert directories correctly : [Attachment 39242] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 18:51:47 PDT 2009


Cameron McCormack <cam at mcc.id.au> has asked  for review:
Bug 29065: svn-unapply doesn't revert directories correctly
https://bugs.webkit.org/show_bug.cgi?id=29065

Attachment 39242: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39242&action=review

------- Additional Comments from Cameron McCormack <cam at mcc.id.au>
The problem is that svnStatus() returns a status line with a newline from one
branch, but without a newline from the other branch.  That caused the regexes
in revertDirectories() to fail to match, because they were looking for a \n at
the end.


More information about the webkit-reviews mailing list