[webkit-reviews] review denied: [Bug 29048] [Qt] make RenderStyle.h compile in winscw compiler. : [Attachment 39217] Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 14:53:38 PDT 2009


Eric Seidel <eric at webkit.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 29048: [Qt] make RenderStyle.h compile in winscw compiler.
https://bugs.webkit.org/show_bug.cgi?id=29048

Attachment 39217: Change compareEqual to a macro in Winscw compiler to get
around "illegal operand" error when compareEqual is defined as template.
https://bugs.webkit.org/attachment.cgi?id=39217&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
There needs to be a comment next to the macro definition as to why it exists.

Also, could you paste the error in the bug?  Are we sure this is the best
solution?  Do we have a bug filed with the winscw compiler?  If so, can we link
to it?


More information about the webkit-reviews mailing list