[webkit-reviews] review denied: [Bug 27105] Blur and focus events are not fired when window is blurred and focused : [Attachment 39108] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 14:49:58 PDT 2009


Eric Seidel <eric at webkit.org> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 27105: Blur and focus events are not fired when window is blurred and
focused
https://bugs.webkit.org/show_bug.cgi?id=27105

Attachment 39108: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39108&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Arv mentioned in-person that he wanted to update this.

changes which were discussed
shouldBeEqualToString (nit)
function for shorter js test (nit)
removal of "focus me" from bottom of test (nit)
comment in dispatchEventsOnWindowAndFocusedNode to document intended behavior.

In general this looks fine to me.


More information about the webkit-reviews mailing list