[webkit-reviews] review denied: [Bug 29005] The values of RuntimeArray are not enumerable : [Attachment 39144] patch suggestion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 14:06:50 PDT 2009


Geoffrey Garen <ggaren at apple.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 29005: The values of RuntimeArray are not enumerable
https://bugs.webkit.org/show_bug.cgi?id=29005

Attachment 39144: patch suggestion
https://bugs.webkit.org/attachment.cgi?id=39144&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Code looks good.

You can test RuntimeArray by passing an NSArray * from Objective-C to
JavaScript. The best place to do that is probably inside DumpRenderTree's
ObjcController.

r- because there's no regression test.


More information about the webkit-reviews mailing list