[webkit-reviews] review granted: [Bug 28682] [Qt] QtWebKit Persistent API : [Attachment 39090] 3rd. try

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 28682: [Qt] QtWebKit Persistent API
https://bugs.webkit.org/show_bug.cgi?id=28682

Attachment 39090: 3rd. try
https://bugs.webkit.org/attachment.cgi?id=39090&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

> +++ WebKit/qt/QtLauncher/main.cpp	(working copy)
> @@ -443,7 +443,7 @@ int main(int argc, char **argv)
>  
>     
QWebSettings::globalSettings()->setAttribute(QWebSettings::PluginsEnabled,
true);
>     
QWebSettings::globalSettings()->setAttribute(QWebSettings::DeveloperExtrasEnabl
ed, true);
> -   
QWebSettings::globalSettings()->setAttribute(QWebSettings::LocalStorageEnabled,
true);
> +    QWebSettings::globalSettings()->enablePersistentStorage();
>  

> @@ -152,6 +151,7 @@ DumpRenderTree::DumpRenderTree()
>      , m_notifier(0)
>  {
>      qt_drt_overwritePluginDirectories();
> +    QWebSettings::globalSettings()->enablePersistentStorage();
>  
>      m_controller = new LayoutTestController(this);
>      connect(m_controller, SIGNAL(done()), this, SLOT(dump()));

When landing, please change these to use
QWebSettings::enablePersistentStorage() instead of
QWebSettings::globalSettings()->enablePersistentStorage().

One could argue that DumpRenderTree should not share the persistent storage
files/path with the default browser location,
to avoid possible side-effects (towards either side :). But that's a minor
detail :)