[webkit-reviews] review denied: [Bug 29024] Make JavaScriptCore compile on platforms with case-insensitive file system : [Attachment 39175] Proposed patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Kent Hansen
<khansen at trolltech.com>'s request for review:
Bug 29024: Make JavaScriptCore compile on platforms with case-insensitive file
system
https://bugs.webkit.org/show_bug.cgi?id=29024

Attachment 39175: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=39175&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
When renaming a file like this you should update all references to the file so
that you don't break the build.

A few other points:
1) Includes should be kept in alphabetical order.
2) The JS prefix is typically reserved for objects that represent an object
within the JavaScript environment (JSArray, JSString, etc).  Maybe this case is
ok for the same reason that JSType is ok.
3) Classes live inside files of the same name.	Since you're renaming the file
I suspect that you should rename the class to match.
4) You should explicit about which platform this is intended to fix.  It's
quite clear that JavaScriptCore compiles on Mac OS X and Windows, both of which
use case-insensitive file systems.  If roll out this change in the future and
only test on those platforms, we'll break whatever platform it is you're trying
to fix here.