[webkit-reviews] review requested: [Bug 28936] Allow [Reflect] on SVG elements : [Attachment 39169] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 7 20:51:51 PDT 2009


Cameron McCormack <cam at mcc.id.au> has asked  for review:
Bug 28936: Allow [Reflect] on SVG elements
https://bugs.webkit.org/show_bug.cgi?id=28936

Attachment 39169: Patch v2
https://bugs.webkit.org/attachment.cgi?id=39169&action=review

------- Additional Comments from Cameron McCormack <cam at mcc.id.au>
I've updated the bindings scripts to special case certain attribute names that
can be found in HTMLNames.  See the hash and sub added in CodeGenerator.pm.

I also made the format and glyphRef attributes on SVGAltGlyphElement use
[Reflect] to test the new functionality.  In doing so, assigning to .format and
.glyphRef now does indeed update the attribute on the element, rather than
throwing immediately.


More information about the webkit-reviews mailing list