[webkit-reviews] review granted: [Bug 29010] Update Canvas3D spec to latest revision : [Attachment 39147] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 7 14:59:51 PDT 2009
Oliver Hunt <oliver at apple.com> has granted Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 29010: Update Canvas3D spec to latest revision
https://bugs.webkit.org/show_bug.cgi?id=29010
Attachment 39147: Patch
https://bugs.webkit.org/attachment.cgi?id=39147&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
These headers have incorrect indentation -- content inside the namespace block
of a header should be indented
> Index: WebCore/bindings/js/JSCanvasArrayBufferConstructor.h
> Index: WebCore/bindings/js/JSCanvasByteArrayConstructor.h
> Index: WebCore/bindings/js/JSCanvasFloatArrayConstructor.h
> Index: WebCore/bindings/js/JSCanvasIntArrayConstructor.h
> Index: WebCore/bindings/js/JSCanvasShortArrayConstructor.h
> Index: WebCore/bindings/js/JSCanvasUnsignedIntArrayConstructor.h
> Index: WebCore/bindings/js/JSCanvasUnsignedShortArrayConstructor.h
Your changes to WebCore/html/canvas/CanvasByteArray.cpp have resulted in
incorrect indenting (in the implementation file we don't indent inside the
namespace)
Other than those minor style quirks, r=me
More information about the webkit-reviews
mailing list