[webkit-reviews] review requested: [Bug 28264] Add Mock Geolocation service for use in LayoutTests : [Attachment 39162] Patch 4 for bug 28264

[bugzilla-daemon at webkit.org]

steveblock at google.com has asked  for review:
Bug 28264: Add Mock Geolocation service for use in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=28264

Attachment 39162: Patch 4 for bug 28264
https://bugs.webkit.org/attachment.cgi?id=39162&action=review

------- Additional Comments from steveblock at google.com
> +++ WebCore/WebCore.base.exp
> 
> Please keep this file alphabetical.
Fixed

> The project files don't seem to know about the mock directory.  I suspect
this
> will cause build breaks.
Fixed. Updated WebCore.pro, GNUmakefile.am and WebCoreCommon.vsprops.

> 1) How does this patch link on non-mac platforms?  You don't seem to have
> implemented the new layoutTestController methods on the other platforms.
I've added stub implementations for non-mac platforms (gtk, win and wx).
Presumably I'm not required
to write the implementations for all platforms?

> 2) This test probably fails on non-mac platforms.  You probably want to add
it
> to the Skipped files to avoid turning the buildbot red.
All Geolocation tests are currently skipped for all platforms other than gtk.
I've
added the new test to the skipped list for gtk given the lack of implementation
of
the LayoutTestcontroller methods.

I haven't been able to test on Windows as the build is currently broken, but
will do so tomorrow.