[webkit-reviews] review denied: [Bug 28264] Add Mock Geolocation service for use in LayoutTests : [Attachment 39137] Patch 3 for bug 28264

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 7 09:00:48 PDT 2009


Adam Barth <abarth at webkit.org> has denied steveblock at google.com's request for
review:
Bug 28264: Add Mock Geolocation service for use in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=28264

Attachment 39137: Patch 3 for bug 28264
https://bugs.webkit.org/attachment.cgi?id=39137&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  Two minor issues:

+++ WebCore/WebCore.base.exp

Please keep this file alphabetical.

The project files don't seem to know about the mock directory.	I suspect this
will cause build breaks.


More information about the webkit-reviews mailing list