[webkit-reviews] review canceled: [Bug 28865] [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack. : [Attachment 39126] fix

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at gmail.com>'s request for review:
Bug 28865: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate
SetCursorEvent hack.
https://bugs.webkit.org/show_bug.cgi?id=28865

Attachment 39126: fix
https://bugs.webkit.org/attachment.cgi?id=39126&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
clearing review(?) flag to address simon's feedback on IRC:

<tronical> tonikitoo, kenneth: I have an idea for teh cursor patch
<tronical> tonikitoo, kenneth: I _love_ your idea of using a dynamic property
instead of an event. that's indeed much more reusable for things like the
graphicsitem than the custom event
<tronical> tonikitoo, kenneth: but currently you do
setProperty("WebCoreCursor", cursor); and _then_ setCursor(cursor);
<tronical> tonikitoo, kenneth: instead it might be easier to distinguish
between the two cases, webcore setting teh cursor and QWidget::unsetCursor()
being called, by simply _not_ calling setCursor() from within WidgetQt.cpp
<tronical> tonikitoo, kenneth: and instead listening to
DynamicPropertyChangeEvent in QWebView