[webkit-reviews] review granted: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 39113] Optimize the QWebPluginInfo::mimeTypes() function.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 7 06:27:42 PDT 2009


Simon Hausmann <hausmann at webkit.org> has granted Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 39113: Optimize the QWebPluginInfo::mimeTypes() function.
https://bugs.webkit.org/attachment.cgi?id=39113&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Looks good to me, r=me

You _could_ probably formulate the QString("%1=%2").arg(s1).arg(s2) stuff
easier by writing first.name() + "=" + second.name(), but that's minor :)


More information about the webkit-reviews mailing list