[webkit-reviews] review requested: [Bug 29006] WebInspector: Make m_windowVisible more consistent with the actual visibility of the inspector. : [Attachment 39139] Suggested patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked Timothy Hatcher
<timothy at hatcher.name> for review:
Bug 29006: WebInspector: Make m_windowVisible more consistent with the actual
visibility of the inspector.
https://bugs.webkit.org/show_bug.cgi?id=29006

Attachment 39139: Suggested patch
https://bugs.webkit.org/attachment.cgi?id=39139&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
We faced a bug that calling:
  page->inspectorController()->show()
  page->inspectorController()->inspect(...)
would not initialize the web inspector correctly.

The call to inspect() will also call InspectorController::show() which will
eventually call setWindowVisible() before the JS frontend has been initialized
and prevent the real call to do its initialization in setWindowVisible()
afterward.

This patch prevent the m_windowVisible flag to be modified if m_frontend has
not been initialized yet.

Adding a bool parameter showInspector to InspectorController::inspect() with a
default value of true would also correct this one problem.