[webkit-reviews] review requested: [Bug 28964] [Chromium] ChromiumDataObject should have getter/setter interface : [Attachment 39135] patch: add getter/setter accessor methods
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 7 01:25:59 PDT 2009
Roland Steiner <rolandsteiner at google.com> has asked for review:
Bug 28964: [Chromium] ChromiumDataObject should have getter/setter interface
https://bugs.webkit.org/show_bug.cgi?id=28964
Attachment 39135: patch: add getter/setter accessor methods
https://bugs.webkit.org/attachment.cgi?id=39135&action=review
------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Made the requested changes:
- content() method returns SharedBuffer*
- added new method PassRefPtr<SharedBuffer> releaseContent(), as it seems that
it'd be useful to have
- clarified the ChangeLog
Renaming the variables after they become private is already on the agenda. :)
On a further note: since I couldn't yet rename the member variables, and the
compiler complained if a getter method had the same name as a variable, I had
to be a bit creative when coming up with names. If you have other/better
suggestions, please let me know!
More information about the webkit-reviews
mailing list