[webkit-reviews] review requested: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 39112] Optimize the QWebPluginInfo::mimeTypes() function.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 5 05:26:48 PDT 2009


Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 39112: Optimize the QWebPluginInfo::mimeTypes() function.
https://bugs.webkit.org/attachment.cgi?id=39112&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #44)
> (From update of attachment 34655 [details])
> Hmm, wouldn't it be better to do this on-demand by having m_mimeTypes
mutable?
> Otherwise it becomes much more expensive to construct a QWebPluginInfo object

> even if you never call mimeTypes() on it?

Right, makes sense to me. :)


More information about the webkit-reviews mailing list