[webkit-reviews] review requested: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 39110] Remove the private classes from QWebPluginDatabase.

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 39110: Remove the private classes from QWebPluginDatabase.
https://bugs.webkit.org/attachment.cgi?id=39110&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #42)
> (From update of attachment 34653 [details])
> Jakub, the patch looks great to me, except for one _tiny_ buglet. I'll r+ it
if
> you
> could leave the d pointers in there. Add the m_plugin, m_database, etc.
> members, that's
> great. But keep the (forward declared) d-pointers, too, even if they're
unused.
> _If_ 
> something goes wrong we can still extend with the d-pointer and keep binary
> compatibility.
> 
> Sorry :)

No problem, I agree with that.

Done.