[webkit-reviews] review denied: [Bug 28991] Drop <definition-src> support : [Attachment 39103] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 5 01:39:22 PDT 2009
Eric Seidel <eric at webkit.org> has denied Cameron McCormack <cam at mcc.id.au>'s
request for review:
Bug 28991: Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991
Attachment 39103: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39103&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I was so excited by this change, and then it looks like you snuck in a
functional change!
0 for (Node* child = firstChild(); child && !srcElement; child =
child->nextSibling()) {
281 if (child->hasTagName(font_face_srcTag))
Before we would use the last source it seems, and now we use the first! If
you're gonna do that, we need a test.
The rest of the change looked fine. Glad to see this go!
More information about the webkit-reviews
mailing list