[webkit-reviews] review denied: [Bug 28960] [Chromium] Need to add manifestUrl to ResourceResponse. : [Attachment 39027] simple patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 28960: [Chromium] Need to add manifestUrl to ResourceResponse.
https://bugs.webkit.org/show_bug.cgi?id=28960

Attachment 39027: simple patch
https://bugs.webkit.org/attachment.cgi?id=39027&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +2009-08-31  Michael Nordman	<michaeln at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Chromium appcache modifications.
> +
> +	   No new tests.

nit: please include a link to this bug report.


> Index: WebCore/bindings/v8/custom/V8DOMApplicationCacheCustom.cpp
...
> +    if (EventListener* listener =
appcache->getAttributeEventListener(toEventID(name)))
> +	  return eventListenerToV8Object(listener);

nit: indentation should be 4 white spaces


> Index: WebCore/platform/network/chromium/ResourceResponse.h
...
> +	   const KURL& getAppCacheManifestURL() const { return
m_appCacheManifestURL; }

getters should not start with "get"... just call this appCacheManifestURL.