[webkit-reviews] review denied: [Bug 28975] Can't upload images with "Hide Extension" set to imgur.com on chromium/mac : [Attachment 39072] Patch.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Nico Weber <thakis at chromium.org>'s
request for review:
Bug 28975: Can't upload images with "Hide Extension" set to imgur.com on
chromium/mac
https://bugs.webkit.org/show_bug.cgi?id=28975

Attachment 39072: Patch.
https://bugs.webkit.org/attachment.cgi?id=39072&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just some minor nits... Please fix and then I can go through this one more
time.


> Index: WebCore/platform/chromium/FileChooserChromium.cpp
> ===================================================================
> +#if PLATFORM(DARWIN)
> +	   // See crbug.com/20857.
> +	   string = pathGetPresentationalName(m_filenames[0]);
> +#else
>	   string = pathGetFileName(m_filenames[0]);
> +#endif

Add braces around this since there is more than one physical line here.




> Index: WebCore/platform/chromium/FileSystemChromiumMac.mm
> ===================================================================

> +  // This has to return a real, existing filename with extension, see
> +  // crbug.com/20857.
> +  return [path lastPathComponent];

Use a 4 space indent throughout.


> +String pathGetPresentationalName(const String& path)
> +{
> +  return [[NSFileManager defaultManager] displayNameAtPath:path];

Use a 4 space indent throughout.