[webkit-reviews] review granted: [Bug 28984] Eliminate the remote user stylesheet loader on Mac/Qt : [Attachment 39088] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 28984: Eliminate the remote user stylesheet loader on Mac/Qt
https://bugs.webkit.org/show_bug.cgi?id=28984

Attachment 39088: Patch
https://bugs.webkit.org/attachment.cgi?id=39088&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  void Page::userStyleSheetLocationChanged()
>  {
> -#if !FRAME_LOADS_USER_STYLESHEET
>      // FIXME: We should provide a way to load other types of URLs than just
> -    // file: (e.g., http:, data:).
> -    if (m_settings->userStyleSheetLocation().isLocalFile())
> -	   m_userStyleSheetPath =
m_settings->userStyleSheetLocation().fileSystemPath();
> +    // file: (e.g., http:).

I guess you don't agree with this FIXME at all. Maybe you should remove it?

You should remove UserStyleSheetLoader from the Qt project files.

You should explain in your ChangeLog how you made the decision that it's OK to
do this.

Do we have regression tests for the user stylesheet code?

r=me