[webkit-reviews] review granted: [Bug 28359] Cleanup: Undo some accidental changes around DOMApplicationCache : [Attachment 39035] cleanup with layout test

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 28359: Cleanup: Undo some accidental changes around DOMApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=28359

Attachment 39035: cleanup with layout test
https://bugs.webkit.org/attachment.cgi?id=39035&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

For the record, the rationale behind this behavior is:

- it's slightly more consistent for a frameless window to be able to construct
a DOMApplicaitonCache, because window.applicationCache would be non-null if
constructed before detaching;
- it's unlikely that any browser will have ApplicationCache compiled in, but
disabled; run-time disabling is needed for clients like Dashboard. So, knowing
that it's non-null can simplify code a little, and will do no harm.

Neither is particularly important, just minor cleanup.

+	 
layoutTestController.overridePreference("WebKitOfflineWebApplicationCacheEnable
d", false);

Does this really work on all platforms? You may need to add this new test to
Skipped list for some (or maybe the platforms that don't have it already skip
all tests http/tests/in appcache?)