[webkit-reviews] review denied: [Bug 28969] Add "sampling profiler" preference, simplify data display when it's set : [Attachment 39063] Comment now addressed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 09:10:41 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has denied  review:
Bug 28969: Add "sampling profiler" preference, simplify data display when it's
set
https://bugs.webkit.org/show_bug.cgi?id=28969

Attachment 39063: Comment now addressed.
https://bugs.webkit.org/attachment.cgi?id=39063&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Opps. Sorry I missed this earlier..

+    if (Preferences.samplingCPUProfiler) {
+      delete columns.average;
+      delete columns.calls;
+    }

You need to use 4 space indents.


More information about the webkit-reviews mailing list