[webkit-reviews] review requested: [Bug 27514] add support for watched expressions : [Attachment 39057] proposed patch - 2009/09/04

[bugzilla-daemon at webkit.org]

Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 27514: add support for watched expressions
https://bugs.webkit.org/show_bug.cgi?id=27514

Attachment 39057: proposed patch - 2009/09/04
https://bugs.webkit.org/attachment.cgi?id=39057&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
final for now, definitely working version

Couple things to clean up, which I'd like to do later, after getting the meat
of the code in:

- I suspect folks won't like the red delete icon that shows up in the right
column; I don't, but couldn't find anything better.  Suggestions?  I was
thinking maybe taking the existing icon I'm using, but convert it to grayscale.


- not really happy with the Add and Refresh buttons.  Too big.	I tried a
smaller font at one point, one pt smaller, but that seemed too small.  Was
wondering about making these link-like instead of button-like.

- there are some changes to existing code elsewhere that should be made;
pfeldman suggested some proposed changes to make the Object.describe() vs
proxy.description stuff simpler, making the console.eval code "public" (maybe
we should move it somewhere else since it's not console specific any more), and
property sorting should move to utilities.  I'd like to do these later.