[webkit-reviews] review denied: [Bug 28969] Add "sampling profiler" preference, simplify data display when it's set : [Attachment 39053] Proposed change
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 4 07:28:05 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 28969: Add "sampling profiler" preference, simplify data display when it's
set
https://bugs.webkit.org/show_bug.cgi?id=28969
Attachment 39053: Proposed change
https://bugs.webkit.org/attachment.cgi?id=39053&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
samplingCpuProfiler should be samplingCPUProfiler per our style guidlines.
> "function": { title: WebInspector.UIString("Function"),
disclosure: true, sortable: true } };
> + if (Preferences.samplingCpuProfiler) {
> + delete columns.average;
> + delete columns.calls;
> + }
Add an empty line before the if.
More information about the webkit-reviews
mailing list